Site Editor: Fix the Root Padding styles #61906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
youknowriad
requested review from
jameskoster,
jasmussen,
tellthemachines and
aaronrobertshaw
youknowriad
commented
May 23, 2024
| @@ -1224,10 +1232,6 @@ export function useGlobalStylesOutputWithConfig( mergedConfig = {} ) { | |||
| return !! getSettings().disableLayoutStyles; | |||
| } ); | |||
|
|
|||
| const blockContext = useContext( BlockContext ); | |||
There was a problem hiding this comment.
This was the bug, who says that useGlobalStylesOutput need to be run within "BlockContext" and why?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -24 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d43c2ef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9209208799
|
2 tasks
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: jasmussen <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in #61860
What?
The GlobalStyles styles generation hook had a hidden dependency towards the "BlockContext". The hook required that it would be applied within that context to generate the right styles for templates. That is a weird dependency. So when we moved the component to generate the styles, the context was not wrapping it anymore, so things started to break.
This PR solves that by removing this dependency in favor of an explicit argument.
Testing Instructions
1- Open a template or a page in the site editor: root padding should be applied
2- Open a template part or a pattern: root padding should not be applied.