Commands: Unify the editor context between post and site editors #61862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
noisysocks,
jorgefilipecosta,
ntsekouras and
aaronrobertshaw
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +226 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2f5e425. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9192502312
|
youknowriad
force-pushed
the
update/pattern-modal-editor
branch
from
50e5905
to
2f5e425
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR moves the "PatternModal" component and their corresponding commands to the editor package rather than leaving this as a site editor only feature. This means that these two commands will be available to folks still loading patterns in the post editor.
It also unifies the commands context between post and site editors opening the door for more cross-editor entity commands.
Testing Instructions
There should be no functional change.
You should see the "duplicate" and "rename" commands when opening patterns in the editor.