Upgrade Storybook to V7 #53520
Merged
Upgrade Storybook to V7 #53520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Build Tooling
|
Size Change: +7 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/storybook
branch
from
8f41031 to
76848fe
Compare
youknowriad
force-pushed
the
update/storybook
branch
from
76848fe to
22101b1
Compare
|
There are also a few regressions #53502 I'm hoping this might resolve. |
|
Ok I've fixed most of the stories, last blocker I've seen is the mdx stories. |
|
Tried several things, I'm kind of stuck, I'm not sure what's preventing the mdx stories from rendering. |
|
Ok, in the last commit, I'm making progress. I managed to make the "introduction" mdx file work (had to change file names to drop the .story suffix) but now importing other markdown files seems broken (as seen in the contributing page) |
|
This should be ready I think. Worth noting that:
|
mirka
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thank you so much for getting this sorted!
I can confirm that the regressions in #53502 are fixed, and I tweaked source-link-loader to work again.
There are a a few smaller things that I'm noticing, but I'll address those later. I'd like to get this PR merged ASAP because the Storybook is very unusable right now 😄
This was referenced Aug 10, 2023
|
Cool, thanks for the fix. |
|
Since Storybook 7.1 there is an option to enable Story's Table of content (to compensate the removing of Docs tab), do you think it worth enabling this option globally by default @youknowriad |
This was referenced Aug 14, 2023
I didn't know about this, thanks for letting us know! I just tried it out, but personally I don't think it's worth the screen space that it takes up, at least in most scenarios right now. And the TOC generation doesn't seem super reliable, as can be seen in the Contributing Guidelines. |
I see 👍
Are you mentioning about the Heading 1 and Heading 2 are skipped? It is because the default value of 
|
Ah, good to know, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While doing the node/npm migration, I've noticed a few messages when installing packages. Among them, the fact that we're using a few deprecated packages. I'm trying to clean these out a little bit.
I noticed that our Storybook dependency was responsible for like 5 of these warnings, so in this PR I'm trying to upgrade it to the latest version. Also upgrading reduces the vulnerabilities number that npm highlights.
How?
.storysuffix to the stories files to avoid having to recreate the Webpack config entirely.Todo