Storybook: Add back subcomponents to props table #53751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Developer Documentation
18 tasks
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #53520
Partially addresses #53541
What?
Add back all the subcomponents to the props tables.
Why?
Storybook 7 does not support the display of subcomponents in the props tables, so they had to be removed.
This PR returns the props tables to what they used to look like, by using the deprecated (but still available)
ArgsTableblock (storybookjs/storybook#20782) instead of the new defaultControlsblock. It is a bandaid fix while we work on documenting the subcomponents in more appropriate ways (#53541).How?
Using a custom Docs page structure so we can use the old
ArgsTablecomponent.Testing Instructions
npm run storybook:devScreenshots or screencast