Override React dependency of React Native #48990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
This was referenced Mar 10, 2023
|
Flaky tests detected in 2574123. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4383805371
|
kevin940726
force-pushed
the
update/npm
branch
2 times, most recently
from
1ac95d8
to
e471f3d
Compare
kevin940726
force-pushed
the
update/npm
branch
2 times, most recently
from
8e3d900
to
3bcbf37
Compare
|
Looks like this was meant as a follow-up to the Node upgrade right? We should be able to retry this. |
This PR is no longer needed as we recently upgraded React Native to a version that uses React 18.2.0. Hence, we can close it. I've tried disabling Click here to display warnings |
|
Awesome thank you @fluiddot we'll take it from there. |
|
Hey @fluiddot I've been doing some cleanup to the dependencies we have based on the list of deprecated packages "npm install" shows. See #53520 #53515 #53478 I've managed to clean a good chunk of them, there's still a dozen left and most of them are due to some native dependencies like "metro" or "react-native-sass-transformer", just wanted to let you know in case it's something that you or your colleagues can help with at some point (there's obviously no urgency here) |
Hey @youknowriad 👋 ! Sure, I'm thinking to create a GitHub issue as a follow-up with the deprecated packages related to React Native. I assume the deprecated packages you're referring to are the following ones, is this accurate? Click here to display deprecated packages and their dependencies
|
|
Yep, great list. That's actually very helpful (to see the parent dependencies). I see there's a few I can help with too. |
|
I've created this GitHub issue #53569 for tracking the task of cleaning up the deprecated packages and including all the information above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds an enhancement to #48950 in order to remove the NPM's
legacy-peer-depsconfiguration option.Why?
Usage of
legacy-peer-depsconfiguration option is not recommended by NPM:How?
0.69.4uses an older React version (18.0.0), however as explained in Dependency conflict when installing dependencies using npm 8 #46443 (comment), seems safe to override the React version for this dependency. This override could be removed once the React Native version is upgraded to0.71or above.legacy-peer-depsoption.package-lock.jsonfile.legacy-peer-depswill make NPM display the following warnings related to other dependency conflicts when installing the depedencies:@mdx-js/[email protected]:NPM warning
[email protected]:NPM warning
[email protected]:NPM warning
[email protected]:NPM warning
[email protected]:NPM warning
[email protected]:NPM warning
In the future, it would be great to solve them to remove the warnings.
Testing Instructions
Follow the same testing instructions outlined in #48950.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A