Fix incorrect aria-describedby attributes for theme patterns #52263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
92 tasks
|
Size Change: +7 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a05b86f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5449613964
|
afercia
reviewed
Jul 4, 2023
| ? ariaDescriptions | ||
| .map( | ||
| ( _, index ) => | ||
| `${ descriptionId }-${ index }` |
There was a problem hiding this comment.
Minor: ${ descriptionId }-${ index } is used one more time, a few lines below, and could be set to a variable.
There was a problem hiding this comment.
These two uses of ${ descriptionId }-${ index } are in separate loops so I'm not sure they can be extracted to a shared variable.
There was a problem hiding this comment.
Right. Aside: I'm not even sure why there is the need to push the notifications/IDs to an array. Is there any case where a pattern can have more than one description?
afercia
approved these changes
Jul 4, 2023
|
Aside: I find some parts of Why this is a variable?
Conversely, why |
aaronrobertshaw
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Thank you for the quick fix @kevin940726 🚀
✅ Using VoiceOver, theme pattern descriptions are read out
✅ Inspecting via dev tools reveals the correct description as well
Aside: I find some parts of grid-item.js pretty confusing. Readability could be improved.
We could make a code quality pass over grid-item.js as a follow-up to avoid blocking this PR.
Edit: I can actually make some of the suggested improvements in #52270 which will refactor the I have done a small clean up of grid-item.js file a bit.grid-item.js in 228cc65 over on #52270
| ? ariaDescriptions | ||
| .map( | ||
| ( _, index ) => | ||
| `${ descriptionId }-${ index }` |
There was a problem hiding this comment.
These two uses of ${ descriptionId }-${ index } are in separate loops so I'm not sure they can be extracted to a shared variable.
aaronrobertshaw
added a commit
that referenced
this pull request
Jul 4, 2023
As per feedback: #52263 (comment)
tellthemachines
pushed a commit
that referenced
this pull request
Jul 7, 2023
|
I just cherry-picked this PR to the update/first-pre-beta-4 branch to get it included in the next release: 4795e31 |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
aaronrobertshaw
added a commit
that referenced
this pull request
Jul 7, 2023
As per feedback: #52263 (comment)
tellthemachines
added a commit
that referenced
this pull request
Jul 7, 2023
* add hint to show template part move (#52395) * Page Content Focus: Ignore page content within a Query Loop block (#52351) * Block Editor: Pass context and className props to editor.BlockEdit filter * Page Content Focus: Ignore content blocks that are within a Query Loop * Patterns: stop endless snackbars appearing (#52012) * Patterns: Distinguish between theme patterns and template parts in category list (#52382) * Allow opt out of auto-creation of Navigation fallback (#52319) * Update welcome guide copy (#52282) * Patterns: Update pattern copy (#52340) * Post Title: The changes should be reflected when previewing a post (#52369) * Update fixed block toolbar (#52123) * update the icons for expanding and collapsing the fixed block toolbar * hide the tools selector item in document tools for fixed toolbar preference * reveal undo, redo and list view buttons * tweaks for show icon labels and hide zoom out for top toolbar option * improve the responsiveness of the fixed block toolbar * remove the overflow rule - bad experiment * update top toolbar test with the new label for buttons * update the toolbar tests to account for moving the collapse button * Drop PHP 5.6 CI jobs (#52345) * Remove PHP 5.6 PHPUnit CI job * Raise version in phpcs / WPCS * Patterns: Add handling of sync status to the wp-admin patterns list page (#52346) * Exit template focus when opening the W menu (#52235) * wrap buttons (#52249) * Update the behavior of the cached undo/redo stack (#51644) Co-authored-by: Ella van Durpe <[email protected]> * Adjust top position (#52248) * Patterns: add a hint about the rename of reusable blocks to menu and inserter (#51771) Co-authored-by: Saxon Fletcher <[email protected]> * Site Editor: update headings hierarchy in the 'Manage all' screens (#52271) * This commit: - updates heading levels on the template and template part pages - passes a `level` prop to Header from Page * update h2 size * Rolling back custom sizes * Rolling back unnecessary classNames There was a rogue space in trunk. Let's let it live * Check randomizer experiment is enabled before rendering button (#52306) * Hide parent selector when parent is 'disabled' or 'contentOnly' (#52264) * Fix incorrect aria-describedby attributes for theme patterns (#52263) * Patterns: rename sync_status and move to top level field on rest return instead of a meta field (#52146) * Fix default block dimensions visibility (#52256) * core/heading * core/details * core/list * core/table * core/video * core/verse * core/social-links * core/site-title * core/site-tagline * core/site-logo * core/post-time-to-read * core/gallery * core/code * core/categories * core/audio * core/archives * Patterns: Display all custom template part areas in sidebar nav (#52355) * Revert phpcs back to PHP 5.6 (#52384) Reverts phpcs PHP compatibility version back to 5.6. * Check if experiment enabled fr this time (#52315) * Navigation: Remove one preloaded endpoint (#52115) * default to showing status (#52226) * Command palette: rename (#52153) * Revise use of “command menu” to “command palette”. Dropping "global" where it was used as well. * Find “command center” and replace with “command palette” * Image block and behaviors: Fix some warnings (#52109) * Fix first warning * Fix second warning - dividing a NaN * Turn off DFM for style book and style editing (#52117) * Add confirmation step when deleting a Template (#52236) * [Command Palette]: Remove suggestion for deleting templates/parts (#52168) * Update stepper styling in Home template details panel (#51972) * Update stepper styling * Remove !important * [Edit Post]: Add toggle fullscreen mode and list view commands (#52184) * Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu (#52222) * Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu * Move lines * !important (#52025) * Navigation in Site View: Readd the edit button (#52111) * Fix UnitControl crashing on regex control characters. Units are now escaped using `escapeRegExp` before concatenating them into a regular expression. Fixes #52211. --------- Co-authored-by: Mitchell Austin <[email protected]> * Patterns: rename wp_block sync_status postmeta to wp_pattern_sync_status (#52232) --------- Co-authored-by: Kai Hao <[email protected]> * Site Editor Frame: Ignore Spotlight in view mode (#52262) * Guide: Place focus on the guide's container instead of its first tabbable (#52300) * Guide: Place focus on the guide's container instead of its first tabbable * Update CHANGELOG * Post editor: Require confirmation before removing Footnotes (#52277) * Post editor: Require confirmation before removing Footnotes Context: #52176 * BlockRemovalWarningModal: Limit width to 40rem * Explain that footnotes are preserved. Add warning to Site Editor * Fix react-dropdown-menu version to avoid breaking change from one of … (#52356) * Fix react-dropdown-menu version to avoid breaking change from one if its dependencies. * Changelog update * move changelog entry to the right place * Update package-lock --------- Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Robert Anderson <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: Ella van Durpe <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Rich Tabor <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Ben Dwyer <[email protected]> Co-authored-by: Mitchell Austin <[email protected]> Co-authored-by: Carlos Bravo <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Timothy Jacobs <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Miguel Fonseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
An error introduced in #51990. Fix incorrect
aria-describedbyusage for theme patterns in the patterns page. Part of #52253.How?
Pass in
ids rather than the descriptions.Testing Instructions
Theme patterns cannot be edited.descriptions.Testing Instructions for Keyboard
This is a screen-reader-only feature. Follow the same steps above and expect the descriptions to be read out from the options.
Screenshots or screencast