Patterns: stop endless snackbars appearing #52012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
glendaviesnz
added
[Type] Bug
92 tasks
|
Size Change: +72 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
glendaviesnz
force-pushed
the
fix/proliferation-of-pattern-snackbars
branch
2 times, most recently
from
196379c to
57b0d25
Compare
glendaviesnz
force-pushed
the
fix/proliferation-of-pattern-snackbars
branch
from
b5b34d6 to
372f6f2
Compare
|
Flaky tests detected in 39f70658551eb1f008c5ae0f652cdeef5f763849. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5462757292
|
glendaviesnz
force-pushed
the
fix/proliferation-of-pattern-snackbars
branch
from
39f7065 to
65aff77
Compare
glendaviesnz
added
Backport to WP 6.7 Beta/RC
glendaviesnz
force-pushed
the
fix/proliferation-of-pattern-snackbars
branch
from
65aff77 to
95ab87f
Compare
aaronrobertshaw
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Much cleaner!
This tests well for me and makes me think we'll have a greater need for this in the Site Editor when managing patterns e.g. renaming and duplicating. Would those actions be more likely than creating patterns in quick succession in the block editor?
We can address that in a follow-up to #52270 of course.
|
Thanks for the review.
For sure. I previously tidied up the snackbars in site editor for template management using a similar approach, so should definitely follow up with some tidy up of the patterns ones. |
I've added notice ids to #52270 however in future we might wish to consolidate them further given you can still currently get separate notices for renaming, duplicating, and deleting, still leaving three notices. Not a scenario to worry about now though I don't think. |
tellthemachines
pushed a commit
that referenced
this pull request
Jul 7, 2023
|
I just cherry-picked this PR to the update/first-pre-beta-4 branch to get it included in the next release: 089d7fd |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
added a commit
that referenced
this pull request
Jul 7, 2023
* add hint to show template part move (#52395) * Page Content Focus: Ignore page content within a Query Loop block (#52351) * Block Editor: Pass context and className props to editor.BlockEdit filter * Page Content Focus: Ignore content blocks that are within a Query Loop * Patterns: stop endless snackbars appearing (#52012) * Patterns: Distinguish between theme patterns and template parts in category list (#52382) * Allow opt out of auto-creation of Navigation fallback (#52319) * Update welcome guide copy (#52282) * Patterns: Update pattern copy (#52340) * Post Title: The changes should be reflected when previewing a post (#52369) * Update fixed block toolbar (#52123) * update the icons for expanding and collapsing the fixed block toolbar * hide the tools selector item in document tools for fixed toolbar preference * reveal undo, redo and list view buttons * tweaks for show icon labels and hide zoom out for top toolbar option * improve the responsiveness of the fixed block toolbar * remove the overflow rule - bad experiment * update top toolbar test with the new label for buttons * update the toolbar tests to account for moving the collapse button * Drop PHP 5.6 CI jobs (#52345) * Remove PHP 5.6 PHPUnit CI job * Raise version in phpcs / WPCS * Patterns: Add handling of sync status to the wp-admin patterns list page (#52346) * Exit template focus when opening the W menu (#52235) * wrap buttons (#52249) * Update the behavior of the cached undo/redo stack (#51644) Co-authored-by: Ella van Durpe <[email protected]> * Adjust top position (#52248) * Patterns: add a hint about the rename of reusable blocks to menu and inserter (#51771) Co-authored-by: Saxon Fletcher <[email protected]> * Site Editor: update headings hierarchy in the 'Manage all' screens (#52271) * This commit: - updates heading levels on the template and template part pages - passes a `level` prop to Header from Page * update h2 size * Rolling back custom sizes * Rolling back unnecessary classNames There was a rogue space in trunk. Let's let it live * Check randomizer experiment is enabled before rendering button (#52306) * Hide parent selector when parent is 'disabled' or 'contentOnly' (#52264) * Fix incorrect aria-describedby attributes for theme patterns (#52263) * Patterns: rename sync_status and move to top level field on rest return instead of a meta field (#52146) * Fix default block dimensions visibility (#52256) * core/heading * core/details * core/list * core/table * core/video * core/verse * core/social-links * core/site-title * core/site-tagline * core/site-logo * core/post-time-to-read * core/gallery * core/code * core/categories * core/audio * core/archives * Patterns: Display all custom template part areas in sidebar nav (#52355) * Revert phpcs back to PHP 5.6 (#52384) Reverts phpcs PHP compatibility version back to 5.6. * Check if experiment enabled fr this time (#52315) * Navigation: Remove one preloaded endpoint (#52115) * default to showing status (#52226) * Command palette: rename (#52153) * Revise use of “command menu” to “command palette”. Dropping "global" where it was used as well. * Find “command center” and replace with “command palette” * Image block and behaviors: Fix some warnings (#52109) * Fix first warning * Fix second warning - dividing a NaN * Turn off DFM for style book and style editing (#52117) * Add confirmation step when deleting a Template (#52236) * [Command Palette]: Remove suggestion for deleting templates/parts (#52168) * Update stepper styling in Home template details panel (#51972) * Update stepper styling * Remove !important * [Edit Post]: Add toggle fullscreen mode and list view commands (#52184) * Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu (#52222) * Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu * Move lines * !important (#52025) * Navigation in Site View: Readd the edit button (#52111) * Fix UnitControl crashing on regex control characters. Units are now escaped using `escapeRegExp` before concatenating them into a regular expression. Fixes #52211. --------- Co-authored-by: Mitchell Austin <[email protected]> * Patterns: rename wp_block sync_status postmeta to wp_pattern_sync_status (#52232) --------- Co-authored-by: Kai Hao <[email protected]> * Site Editor Frame: Ignore Spotlight in view mode (#52262) * Guide: Place focus on the guide's container instead of its first tabbable (#52300) * Guide: Place focus on the guide's container instead of its first tabbable * Update CHANGELOG * Post editor: Require confirmation before removing Footnotes (#52277) * Post editor: Require confirmation before removing Footnotes Context: #52176 * BlockRemovalWarningModal: Limit width to 40rem * Explain that footnotes are preserved. Add warning to Site Editor * Fix react-dropdown-menu version to avoid breaking change from one of … (#52356) * Fix react-dropdown-menu version to avoid breaking change from one if its dependencies. * Changelog update * move changelog entry to the right place * Update package-lock --------- Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Robert Anderson <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: Ella van Durpe <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Rich Tabor <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Ben Dwyer <[email protected]> Co-authored-by: Mitchell Austin <[email protected]> Co-authored-by: Carlos Bravo <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Timothy Jacobs <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Miguel Fonseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes sure only one pattern creation success snackbar appears at time.
Why?
Multiple snackbars currently pile up and obscure the interface
How?
Sets a notice id.
Testing Instructions
In the editor add multiple patterns one after the other and make sure only one snackbar appears at a time.
Screenshots or screencast
Before:
snack-before.mp4
After:
snack-after.mp4