Upgrade wp-prettier to 2.8.5 #49258
Merged
Upgrade wp-prettier to 2.8.5 #49258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
requested review from
ajitbohra,
kevin940726,
gziolo,
ntwb,
nerrad,
ryanwelcher and
ellatrix
as code owners
|
Size Change: +77 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Mar 22, 2023
Comment on lines
+107
to
+109
| const showStopEditingAsBlocks = isEditingAsBlocks && ! isContentLocked; | ||
| const showStartEditingAsBlocks = | ||
| ! isEditingAsBlocks && isContentLocked && props.isSelected; |
There was a problem hiding this comment.
I'm curious why those were needed as separate variables. Is the new version breaking these expressions somehow?
There was a problem hiding this comment.
Not breaking them, the formatting was just not pretty. The conditional JSX:
<>
{ isEditing && isLocked && isSelected && (
<BlockSettings />
) }
</>was already over 80 columns, but the old Prettier didn't break it. The new Prettier breaks it like:
<>
{ isEditing &&
isLocked &&
isSelected && (
<BlockSettings />
) }
</>which looks bad and also adds a new level of indentation for the inner markup. I decided to make it look good again by extracting the condition.
There was a problem hiding this comment.
Agreed, thank you for clarifying 👍
| @@ -43,7 +43,7 @@ const colors = [ | |||
|
|
|||
| const Template: ComponentStory< typeof BorderBoxControl > = ( props ) => { | |||
| const { onChange, ...otherProps } = props; | |||
| const [ borders, setBorders ] = useState< typeof props[ 'value' ] >(); | |||
| const [ borders, setBorders ] = useState< ( typeof props )[ 'value' ] >(); | |||
| @@ -294,7 +294,7 @@ export const showBlockTypes = | |||
| ( type ) => | |||
| ! ( | |||
| Array.isArray( blockNames ) ? blockNames : [ blockNames ] | |||
| ).includes( type ) | |||
| ).includes( type ) | |||
There was a problem hiding this comment.
Oh, I love this. I hated how it added that extra space!
|
Flaky tests detected in f147365. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4490429220
|
gziolo
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
wp-prettierpackage to version 2.8.5 and reformats the codebase.Notable changes:
typeof props[ 'value' ]now get parens for clarity:( typeof props )[ 'value' ]satisfies,inandoutvariance specifiers, ...