Upgrade wp-prettier to v3.0.3 (final) #54775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
requested review from
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Sep 25, 2023
| @@ -6,3 +6,9 @@ f63053cace3c02e284f00918e1854284c85b9132 | |||
|
|
|||
| # Prettier upgrade to 2.6.2. | |||
| 33d84b036592a5bf31af05b7710f3b2b14163dc4 | |||
|
|
|||
| # Prettier upgrade to 2.8.5. | |||
| c56e8a1910ed74f405b74bbb12fe81dea974e5c3 | |||
There was a problem hiding this comment.
Thanks for adding it retroactively 👍
There was a problem hiding this comment.
That's actually the only way to do it, because we need to have the commit sha, which isn't available until we land it.
Yes, that could be caused by the bad peer dependency. Instead of I pushed a commit where the peer deps are updated to v3. |
I did some local testing of the #54749 issue, and although I can't be 100% sure until the new package versions are actually published on NPM and can be installed from NPM, I'm fairly confident that fixing the peer dependencies is all we need to resolve the issue. |
jsnajdr
force-pushed
the
upgrade/prettier-3.0.3-final
branch
from
29e5416 to
8d81651
Compare
gziolo
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54749.
Finalizes the Prettier upgrade to 3.0.3. After a week without discovering any new bugs, I released final 3.0.3 version of
wp-prettier(previous releases were betas), and updated Gutenberg'spackage.jsonfiles to use the final version.I also added the reformatting commits for 3.0.3 (#54539) and 2.8.5 (#49258) to the
.git-blame-ignore-revsfile.