Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade wp-prettier to version 2.8.5 #74775

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Upgrade wp-prettier to version 2.8.5 #74775

merged 4 commits into from
Mar 22, 2023

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Mar 22, 2023

Updates the wp-prettier package to version 2.8.5 and reformats the codebase.

Notable changes:

I also manually fixed formatting of some JSX conditionals, as they looked rather unwieldy after breaking into lines.

@jsnajdr jsnajdr requested a review from tyxla March 22, 2023 13:52
@jsnajdr jsnajdr requested a review from a team as a code owner March 22, 2023 13:52
@jsnajdr jsnajdr self-assigned this Mar 22, 2023
@jsnajdr jsnajdr requested review from worldomonation and a team as code owners March 22, 2023 13:52
@jsnajdr jsnajdr requested a review from a team March 22, 2023 13:52
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 22, 2023
@github-actions
Copy link

github-actions bot commented Mar 22, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-60962
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-60962&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Mar 22, 2023 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect        -66 B  (-0.0%)       +1 B  (+0.0%)
accept-invite          -66 B  (-0.0%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user        -66 B  (-0.0%)       +1 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

tyxla
tyxla approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jsnajdr 🚀

client/blocks/signup-form/index.jsx
Comment on lines -1158 to +1164
{ ! config.isEnabled( 'desktop' ) &&
this.isHorizontal() &&
! this.userCreationComplete() && (
<div className="signup-form__separator">
<div className="signup-form__separator-text">{ this.props.translate( 'or' ) }</div>
</div>
) }
{ showSeparator && (
<div className="signup-form__separator">
<div className="signup-form__separator-text">{ this.props.translate( 'or' ) }</div>
</div>
) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

For the protocol, we discussed that type of changes here.

client/blocks/signup-form/index.jsx Outdated
Comment on lines 1196 to 1198
{ ! config.isEnabled( 'desktop' ) &&
this.isHorizontal() &&
! this.userCreationComplete() && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be another opportunity for abstracting to a variable like you did above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed this one. Thanks for noticing. I pushed a commit that fixes it.

client/signup/difm/components/BrowserView.tsx
@@ -62,7 +62,7 @@ const Container = styled.div< { isSelected?: boolean; isClickDisabled?: boolean
height: 170px;
position: relative;
cursor: ${ ( { isClickDisabled } ) => ( isClickDisabled ? 'default' : 'pointer' ) };
pointer-events: ${ ( { isClickDisabled } ) => ( isClickDisabled ? 'none' : 'default' ) }; ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 😅

@jsnajdr jsnajdr merged commit d6c65e4 into trunk Mar 22, 2023
@jsnajdr jsnajdr deleted the upgrade/wp-prettier-2.8.5 branch March 22, 2023 17:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 22, 2023
@tyxla tyxla mentioned this pull request Mar 23, 2023
Open
@sirbrillig sirbrillig mentioned this pull request Mar 29, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@worldomonation worldomonation Awaiting requested review from worldomonation

Assignees

@jsnajdr jsnajdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsnajdr @matticbot @tyxla