fix: Image caption supports Voice Control #44850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Focus] Accessibility (a11y)
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
|
Hey @geriux. 👋🏻 I requested your review as suggested by GitHub, as you have worked on these components before. However, if you'd prefer me to request someone else, just let me know. Thanks! 🙇🏻 |
|
@geriux removing my review request. I overlooked a portion of the original bug issue: paragraph blocks within column blocks. I need to explore this future. Apologies. 🙇🏻 |
No problem, let me know when it's ready to be reviewed 👍 |
Disable the `accessible` status of the element wrapping the caption Rich Text whenever the caption text input is focused. This allows iOS Voice Control to take action upon the text input itself.
dcalhoun
force-pushed
the
fix/image-caption-supports-voice-control
branch
from
66307ad to
3894d91
Compare
|
@geriux after researching a fix for the Columns block variant of this issue — more specifically any deeply nested block — I would like to keep this PR focused solely on the Image block caption. Resolving the deeply nested block variant introduces some really complex performance issues. 😬 So...this is now ready for review. Thank you! 🙇🏻 |
dcalhoun
force-pushed
the
fix/image-caption-supports-voice-control
branch
from
e15b69c to
432ebdd
Compare
dcalhoun
force-pushed
the
fix/image-caption-supports-voice-control
branch
from
432ebdd to
4c153ca
Compare
geriux
approved these changes
Oct 25, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix iOS Voice Control support allowing moving the cursor within the caption
rich text input.
Why?
Partially addresses wordpress-mobile/WordPress-iOS#19175. This broke user expectations for how
Voice Control should interact with the text input, e.g. the ability to move the
cursor to the beginning of the input.
How?
The static
accessibleprop of the wrapping element prevented Voice Controlfrom taking action on the underlying text input. This disables the
accessiblestatus of the element wrapping the caption Rich Text whenever the caption text
input is focused. This allows iOS Voice Control to take action upon the text
input itself.
Testing Instructions
Test iOS Voice Control
Test iOS Voice Over/Android TalkBack
Screenshots or screencast
Voice Control Before
voice-control-before.MP4
Voice Control After
voice-control-after.MP4
Voice Over Before
voice-over-before.MP4
Voice Over After
voice-over-after.MP4
TalkBack Before
Note2
talkback-before.mp4
TalkBack After
Note2
talkback-after.mp4
Footnotes
The changes in this PR cause an additional element to be focusable via iOS Voice Over: the caption button (original) and the caption text input (new). This is less than ideal, as it is unnecessary and confusing. However, this issue preexists with Android TalkBack and preexists for Paragraphs with a placeholder value with both Android TalkBack and iOS Voice Over. Therefore, I consider it unrelated and should be addressed in a different PR, likely requiring a larger refactor of how accessibility labels are applied to rich text inputs. ↩
I was unable to determine a way to record TalkBack's audio, so the screencast only includes visual examples of the focusable elements. ↩ ↩2