Skip to content

Commit

Permalink
fix: Image caption supports Voice Control (#44850)
Browse files Browse the repository at this point in the history
* fix: Image caption supports Voice Control

Disable the `accessible` status of the element wrapping the caption Rich
Text whenever the caption text input is focused. This allows iOS Voice
Control to take action upon the text input itself.

* docs: Add changelog entry
  • Loading branch information
dcalhoun authored Oct 25, 2022
1 parent f808cff commit a498b86
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/block-library/src/image/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ export class ImageEdit extends Component {
<BlockCaption
clientId={ this.props.clientId }
isSelected={ this.state.isCaptionSelected }
accessible
accessible={ ! this.state.isCaptionSelected }
accessibilityLabelCreator={ this.accessibilityLabelCreator }
onFocus={ this.onFocusCaption }
onBlur={ this.props.onBlur } // Always assign onBlur as props.
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ For each user feature we should also add a importance categorization label to i

## 1.84.0
- [*] Upgrade compile and target sdk version to Android API 31 [#44610]
- [*] [iOS] Fixed iOS Voice Control support within Image block captions. [#44850]

## 1.83.0
* No User facing changes *
Expand Down

0 comments on commit a498b86

Please sign in to comment.