Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image caption supports Voice Control #44850

Merged
merged 2 commits into from
Oct 25, 2022
Merged

fix: Image caption supports Voice Control #44850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3894d91
fix: Image caption supports Voice Control
dcalhoun Oct 11, 2022
4c153ca
docs: Add changelog entry
dcalhoun Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/image/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ export class ImageEdit extends Component {
<BlockCaption
clientId={ this.props.clientId }
isSelected={ this.state.isCaptionSelected }
accessible
accessible={ ! this.state.isCaptionSelected }
accessibilityLabelCreator={ this.accessibilityLabelCreator }
onFocus={ this.onFocusCaption }
onBlur={ this.props.onBlur } // Always assign onBlur as props.
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For each user feature we should also add a importance categorization label to i

## Unreleased
- [*] Upgrade compile and target sdk version to Android API 31 [#44610]
- [*] [iOS] Fixed iOS Voice Control support within Image block captions. [#44850]

## 1.83.0
* No User facing changes *
Expand Down