Placeholder: Add blurred background to work in nested cases. #43379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +54 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
mtias
approved these changes
Aug 18, 2022
jasmussen
commented
Aug 18, 2022
| min-width: 100px; | ||
|
|
||
| // Blur the background so layered dashed placeholders are still visually separate. | ||
| // We also provide a semitransparent background so as to allow duotones to sheen through. | ||
| backdrop-filter: blur(100px); |
There was a problem hiding this comment.
The included autoprefixer should take care of that, which is why I didn't include it. But excellent sanity check, thank you!
This was referenced Sep 25, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #43364.
This PR adds a background to the new dashed placeholder style. Specifically a very semitransparent background, but with a lot of blur. That ensures the dashed style will work better in nested contexts, and with complex backgrounds underneath.
Here are a range of screenshots showing a Cover image with a background photo, and a dashed style image placeholder inside, as well as placeholders for Featured Image, Site Logo, and more:
With faux duotone applied (this needs a separate PR to actually be user-settable)
Testing Instructions
Here's some test content:
Be sure all placeholders look good.