Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving placeholder visibility #43364

Closed
jameskoster opened this issue Aug 18, 2022 · 1 comment · Fixed by #43379
Closed

Improving placeholder visibility #43364

jameskoster opened this issue Aug 18, 2022 · 1 comment · Fixed by #43379
Assignees
@jasmussen
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Post Featured Image Affects the Post Featured Image Block [Block] Site Logo Affects the Site Logo Block [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

The placeholder that has been implemented for the Featured Image, Site Logo, Cover, and soon Image block is a nice step forwards:

Screenshot 2022-08-18 at 10 07 47

But there are a couple of scenarios where clarity can be an issue. For example if it appears on a noisy background:

Screenshot 2022-08-18 at 10 12 28

Or when they overlap (e.g. a Featured image in a Cover):

Screenshot 2022-08-18 at 10 03 50

Is there anything we can do to make this more visually robust?
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Post Featured Image Affects the Post Featured Image Block [Block] Site Logo Affects the Site Logo Block labels Aug 18, 2022
@jasmussen jasmussen mentioned this issue Aug 18, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 18, 2022
@jasmussen
Copy link
Contributor

#43379 makes great progress in making this work. Let me know what you think!

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Post Featured Image Affects the Post Featured Image Block [Block] Site Logo Affects the Site Logo Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Placeholder: Add blurred background to work in nested cases. WordPress/gutenberg
3 participants
@jameskoster @jasmussen @priethor