Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder: Add blurred background to work in nested cases. #43379

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Placeholder: Add blurred background to work in nested cases. #43379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/components/src/placeholder/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,18 @@
border-radius: inherit;
display: flex;
box-shadow: none;
background: none;
min-width: 100px;

// Blur the background so layered dashed placeholders are still visually separate.
// We also provide a semitransparent background so as to allow duotones to sheen through.
backdrop-filter: blur(100px);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The included autoprefixer should take care of that, which is why I didn't include it. But excellent sanity check, thank you!

safari

background-color: rgba($white, 0.1);

// Invert the colors in themes deemed dark.
.is-dark-theme & {
background-color: rgba($black, 0.1);
}

.components-placeholder__fieldset {
width: auto;
}
Expand Down