Navigation: adjust mobile close button position when admin bar is visible #41664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +94 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jun 22, 2022
|
Hi all, Thanks for working on this! However, this change seems to be pushing also the navigation items down. Am I missing something?
|
|
In the example above, the navigation was set to display the overlay menu only for mobile.
The issue can only be seen on the front of the site. No navigation is affected in the editor. |
👋 Could you share which theme this is in, or the markup for this menu? I'm guessing the 'Start a project' button is absolutely positioned, or it's styled in another way which means the top margin doesn't affect it. Either way, I can take a look and spin up another PR. |
|
Hi @mikachan 👋 , the theme is something that I'm working on now, and it hasn't yet been released. The button is placed normally next to the navigation block in a Row block. Anyway, this is the markup of the entire header. I've just tested this with Twenty Twenty-Two, and the issue can be seen with the theme too. Please let me know if there is anything that I can help with! |
|
Thanks, this helps a lot! I understand now, this is affecting items that aren't even inside an open mobile menu. Good spot! This should fix the issue: #41949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adjusts the position of the close button in the mobile navigation dialog when the user is logged in (when the admin bar is visible). Before, the close button would seem to jump in position compared to the hamburger menu.
Why?
This isn't an issue when the admin bar is not visible, so this aligns the two views.
How?
I've added a top margin to the dialog div which matches the
$admin-bar-heightor$admin-bar-height-big, depending on the breakpoint.Testing Instructions
Screenshots or screencast
Before:
Screen.Recording.2022-06-10.at.16.25.22.mov
After:
Screen.Recording.2022-06-10.at.16.23.08.mov