Navigation: make additional top margin specific to open modal #41949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +19 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #41664, we added a top margin to the mobile menu when the admin bar is visible (or when the user is logged in). I didn't realise this also affects the nav items when the mobile menu is closed, which was unintentional. This change only applies the top margin when the mobile menu is open.
Why?
Fix a spacing bug introduced in #41664.
How?
By making the selector more specific to an open modal.
Testing Instructions
Screenshots or screencast
Before:
After:
