Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: Jumping Close Navigation Button #5975

Closed
iamtakashi opened this issue May 5, 2022 · 1 comment · Fixed by #6082
Closed

Blockbase: Jumping Close Navigation Button #5975

iamtakashi opened this issue May 5, 2022 · 1 comment · Fixed by #6082

Comments

@iamtakashi
Copy link
Contributor

In Blockbase, a part of the ponyfill CSS changes the position of the close navigation button. That seems to be making the button jump.

Screen Recording 5-5-2022 at 10 58 PM

If I disable the part of CSS, it seems to resolve the issue.

Screen Recording 5-5-2022 at 10 59 PM

Why do we need this? Is it a leftover fix that we needed before? Can we now get rid of it?

@mikachan
Copy link
Member

I'm not sure why we added this originally, my guess is that it could've been to fix the position of the close button when the admin-bar is visible. I've opened up a Gutenberg PR to fix this: WordPress/gutenberg#41664

Removing these styles in Blockbase seems to work fine. Opened up a PR for this too: #6082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants