Core data: create type for undo state and initialize atomically #39659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
Part of #39211 In this patch we're adding some types to the undo state tracked in the core data store. Additionally we're intializing it in one atomic operation whereas previously that took two partial assignments. Futher, a JSDoc comment has been moved from its previously erroneous location and back to the function it describes. This error had been overlooked in a previous change to the module. The purpose is to remove type issues when toggling on TypeScript across the `core-data` package. This is almost entirely a type-level change but the initialization of `UNDO_INITIAL_STATE` has been collapsed into a single assignment. Verify that the editor undo/redo functionality works as expected. Given that the one code change impacts the initialization it should be quickly obvious if there's a problem or regression with undo/redo.
dmsnell
force-pushed
the
core-data/fix-typing-issues-undo-state
branch
from
cd7ed94 to
694499b
Compare
adamziel
approved these changes
Mar 31, 2022
|
Thanks! E2e failures seem unrelated so I restarted them |
dmsnell
added a commit
that referenced
this pull request
Mar 31, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
dmsnell
added a commit
that referenced
this pull request
Apr 1, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #39211
In this patch we're adding some types to the undo state tracked
in the core data store. Additionally we're intializing it in one
atomic operation whereas previously that took two partial assignments.
Futher, a JSDoc comment has been moved from its previously erroneous
location and back to the function it describes. This error had been
overlooked in a previous change to the module.
The purpose is to remove type issues when toggling on TypeScript
across the
core-datapackage.This is almost entirely a type-level change but the initialization
of
UNDO_INITIAL_STATEhas been collapsed into a single assignment.Testing
Verify that the editor undo/redo functionality works as expected.
Given that the one code change impacts the initialization it should
be quickly obvious if there's a problem or regression with undo/redo.