Core data: Fix some typing issues #39212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
requested review from
nerrad,
ajitbohra,
mkaz and
ryanwelcher
as code owners
|
Size Change: +566 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
gziolo
added
[Package] Core data
adamziel
reviewed
Mar 4, 2022
packages/core-data/src/actions.js
Outdated
| @@ -607,8 +603,8 @@ export const saveEntityRecord = ( | |||
| * `saveEntityRecord`, `saveEditedEntityRecord`, and | |||
| * `deleteEntityRecord`. | |||
| * | |||
| * @return {Promise} A promise that resolves to an array containing the return | |||
| * values of each function given in `requests`. | |||
| * @return {(thinkArgs: Object) => Promise} A promise that resolves to an array containing the return | |||
There was a problem hiding this comment.
Looking at the original PR, I think this was meant to say thunk – I went ahead and updated it
Suggested change
| * @return {(thinkArgs: Object) => Promise} A promise that resolves to an array containing the return | |
| * @return {(thunkArgs: Object) => Promise} A promise that resolves to an array containing the return |
There was a problem hiding this comment.
Thanks for the update; you were spot on - thunkArgs - We could have made a better type here but mostly I want to get things set so we don’t have errors once we turn on TypeScript
adamziel
approved these changes
Mar 4, 2022
dmsnell
added a commit
that referenced
this pull request
Mar 31, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
dmsnell
added a commit
that referenced
this pull request
Apr 1, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39211
Description
Fixes a few small issues with the JSDoc types in
@wordpress/core-data.undefinedwas the wrong return type for the given files. removing that type to remove the error and leaving them untyped.undoIgnoreparameter is optional foreditEntityRecord__experimentalBatchis a function that returns aPromise, not aPromiseTesting Instructions
Audit the types. As a type-only change this won't impact the built files
Types of changes
This is a type-only change and won't impact the build.
Checklist:
*.native.jsfiles for terms that need renaming or removal).