Core Data: Check for presence of entity config before testing plural form #39476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Mar 16, 2022
…form. When auto-generating method names for various entities in the data system we want to use manually-listed plural forms if they exist. Previously, however, we've been assuming that when we search for an entity's config that it exists. While this probably hasn't been a real source of bugs it does present an opportunity for an invalid-type runtime exception. In this patch we're verifying that the config exists before we access the `plural` property, eliminating the opportunity for the rutnime crash.
adamziel
force-pushed
the
core-data/check-entity-config-presence
branch
from
52c54fd to
a764b9b
Compare
dmsnell
added a commit
that referenced
this pull request
Mar 31, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
dmsnell
added a commit
that referenced
this pull request
Apr 1, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #39211
When auto-generating method names for various entities in the data system we
want to use manually-listed plural forms if they exist.
Previously, however, we've been assuming that when we search for an entity's
config that it exists. While this probably hasn't been a real source of bugs
it does present an opportunity for an invalid-type runtime exception.
In this patch we're verifying that the config exists before we access the
pluralproperty, eliminating the opportunity for the rutnime crash.Testing Instructions
This patch adds a safety guard for a place where we access a property from
an object which could be null or undefined. Audit the code to ensure that the
elimination of the possible type error doesn't cause unintended side-effects.