[Mobile] - Enable font size and line height support and addresses Android issues #38205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2022 11:57
geriux
added
[Status] In Progress
|
Size Change: -430 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
added 7 commits
January 26, 2022 16:40
… set the minimum line-height to 1 to prevent unexpected results on Android.
geriux
added
the
Mobile App - Automation
geriux
changed the title
1 task
This was referenced Jan 27, 2022
antonis
reviewed
Jan 28, 2022
...ive-aztec/android/src/main/java/org/wordpress/mobile/ReactNativeAztec/ReactAztecManager.java
Show resolved
Hide resolved
geriux
deleted the
rnmobile/fix/line-height-android-block-based-themes
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables font size and line-height support on mobile for block-based themes.
It also includes some fixes on Android and the Heading block.
On Aztec Android, different scales are added to the Heading block. Unfortunately, I couldn't find an easy way to disable this for an specific case like block-based themes. So for now the approach is the following:
isHeadingBlockto check if the current tag is from a Heading block, e.gh1,h2, etc.setBlockTypeis called, it triggetssetFontSize, for cases when the Heading block was already created but its level changes e.g fromh1toh2.This also limits the minimum value that can be set for line-height to
1, lower values break on Android where the block doesn't show the correct height.Testing Instructions
Font size (block-based themes: Calvin, Quadrat, etc.)
Test case 1
Test case 2
h1,h3,h4Test case 3
H1levelH4levelDefaultfont sizeLine-height (block-based themes: Calvin, Quadrat, etc.)
Test case 1
Test case 2
H1Test case 3
1Font size (standard theme: Seedlet)
Test case 1
Test case 2
H1H3Line-height (standard theme: Seedlet)
Test case 1
Screenshots
Font size (block-based themes: Calvin, Quadrat, etc.)
Line-height (block-based themes: Calvin, Quadrat, etc.)
Font size (standard theme: Seedlet)
Line-height (standard theme: Seedlet)
Test case 1
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).