Heading Span - Reset previous font metrics if the font spacing changes #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
antonis
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Thank you for you work on this @geriux 🙇
I tested the solution via Approved in WordPress/gutenberg#38205 (review) and everything worked as expected. The code changes also look consistent to me 🎉
geriux
deleted the
feature/heading-span-restore-metrics-for-spacing-updates
branch
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This PR adds another check to take into account before resetting the font metrics, by checking if the font spacing changed..
Test
Use the test instructions from this Gutenberg PR.
Review
@antonis
Make sure strings will be translated:
strings.xmlas a part of the integration PR.