Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Enable font size and line height #17833

Closed
wants to merge 1 commit into from
Closed

[Gutenberg] Enable font size and line height #17833

wants to merge 1 commit into from

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jan 27, 2022

To test check the Gutenberg PR description.

Regression Notes

  1. Potential unintended areas of impact
    Block editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    TBD

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Gutenberg Editing and display of Gutenberg blocks. label Jan 27, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 27, 2022 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 64858. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@geriux geriux requested a review from antonis January 27, 2022 22:23
@geriux geriux added this to the 19.2 milestone Jan 27, 2022
This was referenced Jan 27, 2022
Merged
Merged
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

antonis
antonis approved these changes Jan 28, 2022
View reviewed changes
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#38205 (review) 🎉

@geriux geriux removed this from the 19.2 milestone Jan 31, 2022
@geriux
Copy link
Contributor Author

geriux commented Jan 31, 2022

Closing since it was only needed for testing.

@geriux geriux closed this Jan 31, 2022
@ghost ghost mentioned this pull request Feb 18, 2022
Closed
@geriux geriux deleted the gutenberg/enable-font-size-line-height branch June 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @antonis