[RNMobile][Embed block] Add the top 5 specific embed blocks to the Block inserter list #34967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - i.e. Android or iOS
fluiddot
changed the title
2 tasks
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
fluiddot
commented
Sep 21, 2021
fluiddot
commented
Sep 21, 2021
fluiddot
commented
Sep 21, 2021
fluiddot
commented
Sep 21, 2021
packages/block-editor/src/components/inserter/block-types-tab.native.js
Outdated
Show resolved
Hide resolved
fluiddot
commented
Sep 21, 2021
fluiddot
commented
Sep 21, 2021
fluiddot
commented
Sep 21, 2021
fluiddot
force-pushed
the
rnmobile/embed-block-add-top-providers-inserter
branch
from
1e6741a to
ebf8b0c
Compare
jd-alexander
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Thanks for these changes @fluiddot I reviewed the code and I learnt a lot from the comments you provided with thoughts on your approach to refactoring the BlockIcon. On iOS, I was able to verify that the respective embed blocks that were enabled were shown within the Inserter ( except Instagram which won't be enabled until the Jetpack embed variants are included). My Android Studio is broken so I wasn't able to figure up an Android build to verify the changes there. I will do that tomorrow. 👍🏾
…rter # Conflicts: # packages/block-editor/src/components/inserter/block-types-tab.native.js
Thanks @jd-alexander for reviewing the PR ❤️ ! I'd like to note that I recently pushed a commit to solve a conflict, the main change is that the
Ok, I'll wait for your feedback on Android before merging, in my case, I didn't find any issue but better to double-check it 👍, thanks 🙇 ! |
|
@fluiddot the changes look beautiful on Android. Good job! 🚢 |
This reverts commit 55bf89b.
|
As it was commented here, I've just disabled the colored icon versions for the embed blocks in this commit. @jd-alexander let me know if you'd like to do another review due to this change or otherwise, we're safe to merge the PR, thanks 🙇 ! |
I would just do a quick check to see how it looks on my side! I have never seen the icons rendered without the colors. |
|
@fluiddot all is well from my side! Verified that the icons are in unison with the rest that is within the Inserter. LGTM! |
fluiddot
deleted the
rnmobile/embed-block-add-top-providers-inserter
branch
|
👋 @fluiddot, I'm testing the Gutenberg Mobile release and had a question about testing instructions. I see the colored icons were removed here (in this comment), but I wonder if it should be removed from the PR description. The reason I ask is that when testing the release, to know what to tests I first went to the Gutenberg Mobile PR, then came here and saw mentioned of colored icons. Then when I didn't see colored icons in the app, I came back to the comments here and found it had been removed. |
@guarani Thanks for pointing this out 🙇 , I'm afraid I forgot to update that part of the PR description after we removed the colored icons from the changes. I'll review all potential references and update them as soon as possible to prevent any misleading when testing 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3995Description
Add the top 5 specific embed blocks to the Block inserter list
and use the colored version of the icons:Instagram(NOTE: This block is not added yet, it will when we tackle this issue)EDIT: As mentioned in this comment, the colored versions of the icons won't be used.
How has this been tested?
Screenshots
iOS:
Android:
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).