Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Include Jetpack embed variants #3951

Closed
jd-alexander opened this issue Sep 11, 2021 · 1 comment · Fixed by #4008
Closed

[Embed block] Include Jetpack embed variants #3951

jd-alexander opened this issue Sep 11, 2021 · 1 comment · Fixed by #4008

Comments

@jd-alexander
Copy link
Contributor

Description

Jetpack has embed variants for some of the providers we support such as Facebook. The embed block should support all embed variants in Gutenberg and Jetpack.

We would have to refactor how we integrate blocks from Jetpack because these variations overwrite the core ones (reference). This means that we would need to import the Jetpack's embed variations before registering the core blocks for this purpose.


Issue inspired by the discussion on this PR WordPress/gutenberg#34626

@fluiddot
Copy link
Contributor

Heads up that there's a new variant being implemented in Jetpack to support Getty Images provider (more info in this PR), so it would be great to include it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants