-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SmartFrame embedding #21101
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I gave it a first pass below.
@jeherve Your feedback really shaped the PHP code up! Thank you so much. Addressed all. |
Is this ready for another review now? |
@jeherve Yes! Forgot to change the labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me. 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving again after our discussion in p1632232389218000-slack-CBG1CP4EN
4e11c8c
to
7719df8
Compare
Great news! One last step: head over to your WordPress.com diff, D66901-code, and commit it. Thank you! |
r232103-wpcom |
Changes proposed in this Pull Request:
This PR adds support for SmartFrame embedding. It's heavily inspired by (more like shamelessly copies) gettyimages embedding logic. It adds support for:
[jetpack_smartframe script-id="6ae67829d1264ee0ea6071a788940eae" image-id="mantymetsa_1630927773870" width="100%" max-width="1412px"]
.Fixes #21062
Jetpack product discussion
Context here: p58i-b8R-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
[jetpack_smartframe script-id="6ae67829d1264ee0ea6071a788940eae" image-id="mantymetsa_1630927773870" width="100%" max-width="1412px"]
. Onlyscript-id
andimage-id
are required, and the embed should work without the rest.<script src="https://embed.smartframe.io/6ae67829d1264ee0ea6071a788940eae.js" data-image-id="mantymetsa_1630927773870" data-width="100%" data-max-width="1412px"></script>