Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Add the top 5 specific embed blocks to the Block inserter list #3995

Merged
merged 12 commits into from
Sep 30, 2021
Merged

[Embed block] Add the top 5 specific embed blocks to the Block inserter list #3995

merged 12 commits into from
Sep 30, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Sep 20, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#34967

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#34967.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Sep 20, 2021
@fluiddot fluiddot mentioned this pull request Sep 20, 2021
Merged
7 tasks
@fluiddot fluiddot linked an issue Sep 20, 2021 that may be closed by this pull request
[Embed block] Add the top 5 specific embed blocks to the Block inserter list #3278
Closed
@fluiddot fluiddot marked this pull request as ready for review September 21, 2021 10:21
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 21, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

jd-alexander
jd-alexander approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34967 (review)

@fluiddot
Copy link
Contributor Author

Heads up that I'm going to make a little change in the Gutenberg PR to disable the colored icon versions as has been discussed internally (p1632907802004300-slack-C01MTUVN9T3).

cc @jd-alexander

@fluiddot fluiddot added this to the 1.63.0 (18.4) milestone Sep 30, 2021
@fluiddot fluiddot enabled auto-merge September 30, 2021 08:15
@fluiddot fluiddot merged commit 139c76c into develop Sep 30, 2021
@fluiddot fluiddot deleted the embed-block-add-top-providers-inserter branch September 30, 2021 11:51
@guarani guarani mentioned this pull request Oct 1, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

@ceyhun ceyhun Awaiting requested review from ceyhun

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Task
Projects
None yet
Milestone
1.63.0 (18.4)
Development

Successfully merging this pull request may close these issues.

[Embed block] Add the top 5 specific embed blocks to the Block inserter list
2 participants
@fluiddot @jd-alexander