[RNMobile] Blur inserter search when keyboard closes #34278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
2 tasks
hypest
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
LGTM! Tested on Android physical devices and I see the search box becoming unfocused (blurred) when the virtual keyboard dismisses, as intended. 🎉
One nit to cover in a separate PR perhaps and it's not directly related to the changes in this PR but, it'd be helpful to have an inline comment explaining the use of a timeout in the onCancel() to do the blur. I'd assume it has something to do with when the blur can succeed related to the render phases.
|
BTW, let's wait for the gb-mobile side PR to also get approved before doing the merge domino. |
annezazu
added
[Type] Enhancement
jhnstn
added a commit
that referenced
this pull request
Aug 25, 2021
* Use flexbox for tab positioning * Allow bottomsheet to scroll while fullscreen Changes cherry picked from c5aa56c * Fix input height * Fix active search cut off * Use fullscreen on Android only * Add prop to allow drag indicator on Android * Pass in initial number of items to render * Update logic to show the drag indicator * Fix block inserter scroll view height (#34139) * Fix block inserter scroll view height Leverages flex layout properties rather than explicit height to ensure the scroll view coordinates its height with its sibling elements. * Rename Sass selectors for improved clarity Avoid referencing "tabs" as that is not relevant as this level of the UI. * Enable inserter block search * Fix revert issue * Blur inserter search when keyboard closes (#34278) Co-authored-by: jhnstn <[email protected]> * Filter embed blocks from Inserter search block list Co-authored-by: jhnstn <[email protected]> Co-authored-by: David Calhoun <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This blurs the inserter search input when the keyboard is manually closed.
Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#3871
How has this been tested?
(* while this change is not platform specific, the iOS devices tested did not have a way to close the keyboard outside of using the existing cancel flows )
Screenshots
search_input_focus.mp4
Pixel 5, Android 11
Types of changes
Adds Keyboard listener to the mobile search control component
Checklist:
*.native.jsfiles for terms that need renaming or removal).