[RNMobile] Full screen block inserter menu for Android #34129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes cherry picked from c5aa56c
7 tasks
|
Size Change: +147 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
* Fix block inserter scroll view height Leverages flex layout properties rather than explicit height to ensure the scroll view coordinates its height with its sibling elements. * Rename Sass selectors for improved clarity Avoid referencing "tabs" as that is not relevant as this level of the UI.
7 tasks
This was referenced Aug 24, 2021
mchowning
approved these changes
Aug 24, 2021
jhnstn
force-pushed
the
rnmobile/full-screen-inserter-redux
branch
from
f7b0090 to
6897116
Compare
annezazu
added
[Feature] Inserter
mchowning
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Retested and this is working great. Fixes for both the keyboard focus issue (text field not losing focus when the keyboard is dismissed) and the filtering issue (hidden embeds showing up when filtering the inserter) are working as expected. Great work @jhnstn !
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change set makes the inserter full screen on Android.
Fixes #34124
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).