-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNmobile] Fix iOS inserter search focus issue #34336
Conversation
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is working well, and code looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great!
I first reproduced the issue on trunk
using an external keyboard connected to a physical iPhone. Then I switched to this branch and verified the fix works by using the block inserter search while still on the external keyboard.
Description
This fixes an issue where the inserter search input losses focus immediately when tapped.
The issue is iOS only.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3877
How has this been tested?
Connect Hardware Keyboard
option selected.Screenshots
Types of changes
#34278 introduced a fix for cases when the inserter search was active and the keyboard is manually closed on Android. This left the inserter in an active state when , with the keyboard closed, should return to an inactive state.
This changes that flow to apply to Android only.
Checklist:
*.native.js
files for terms that need renaming or removal).