Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Separate safari fix. #32538

Closed
wants to merge 1 commit into from
Closed

Try: Separate safari fix. #32538

wants to merge 1 commit into from

Conversation

jasmussen
Copy link
Contributor

Description

When using an old WordPress theme that doesn't provide an editor style, in Safari, there can be some background flickering. Here's Independent Publisher 2:

test

This fix, which I don't love, fixes it:

attempt

I don't love the fix because:

  • Transforms change the rendering onto the GPU, part of the fix, but there are usually overflow-related side effects.
  • It isn't clear when this regression initially happend. We've been looking separately at Safari related issues in Try: Safari flickering fix, take two #32188, which were also fixed by rendering on the GPU.
  • The original issue was reported here, but I haven't been able to reproduce the precise issue, so I'm not even sure this is a fix.

How has this been tested?

Use an old theme, use Safari, and use a lot of content on the page, then scroll quickly.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@jasmussen jasmussen added the Browser Issues Issues or PRs that are related to browser specific problems label Jun 9, 2021
@jasmussen jasmussen self-assigned this Jun 9, 2021
@jasmussen
Copy link
Contributor Author

Closing this one in favor of #32575, which is streamlined.

@jasmussen jasmussen closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant