-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text: move implementation specific delete and enter handling #31644
Merged
ellatrix
merged 4 commits into
trunk
from
try/rich-text-move-implementation-specific-delete-enter
May 10, 2021
Merged
Rich text: move implementation specific delete and enter handling #31644
ellatrix
merged 4 commits into
trunk
from
try/rich-text-move-implementation-specific-delete-enter
May 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +17 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
7 tasks
ellatrix
deleted the
try/rich-text-move-implementation-specific-delete-enter
branch
May 10, 2021 15:03
ellatrix
changed the title
Rich text: remove implementation specific delete and enter handling
Rich text: move implementation specific delete and enter handling
May 10, 2021
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #31637 and generally separating rich text specific handling for block and general rich text handling.
How has this been tested?
Everything should work as before. We have plenty of test coverage for delete, split and enter behaviour.
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).