Rich text: fix showing toolbar when caret enters formatting (and extract as implementation detail for the block editor) #31664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 10, 2021
| __unstableMarkAutomaticChange, | ||
| } = useDispatch( blockEditorStore ); | ||
|
|
||
| useEffect( () => { |
There was a problem hiding this comment.
We must create a separate component so we can use hooks.
|
Size Change: +505 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
ellatrix
changed the title
ellatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes this long standing issue.
Related: #31644.
This PR also extracts implementation specific behaviour (communicating entering and exiting formatting) from rich text's core to the implementation for blocks.
The actions can be called on an async effect so toolbar rendering doesn't block selection change.
How has this been tested?
See e2e test.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).