Rich text: extract internal delete handling #31637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +49 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/rich-text-extract-delete
branch
2 times, most recently
from
5e622e4 to
04a1377
Compare
This was referenced May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparatory work for putting all rich text behaviours into a single ref callback hook, while also splitting the large rich text file.
The remaining part of key down handling (Enter and Delete that splits the text areas) should eventually move to the block specific implementation of rich text.
How has this been tested?
Everything should work as before and we have plenty of e2e test coverage.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).