Remove unnecessary space in HTML tags #30585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rich-text component was adding a space to the opening root tag of HTML before passing it to Aztec. I don't think this resulted in any bugs, so this change is more of a code clean-up.
guarani
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
The snapshot tests failed because some of them expected a space in opening tags, e.g.: I updated the failing tests using: |
geriux
approved these changes
Apr 8, 2021
@geriux I'd forgotten to check ordered lists ( I went to test the "Ordered list settings" now and noticed they are not working 🤔 Setting the start value or "reverse list numbering" isn't working. I tested the current WPiOS 17.0 and they don't seem to be working their either. (It does work when I preview the post–since the right HTML is produced by the editor–it's just that the editor itself doesn't reflect these changes. I'm thinking that it's a separate issue though and I can merge this and create a separate issue for that, what do you think? |
Oh! I missed that 😓
Yeah, I think this one is unrelated and we can work on that bug on another issue. Thanks! |
Sounds good! I created an issue here: #30623 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rich-text component was adding a space to the opening root tag of HTML before passing it to Aztec. I don't think this resulted in any bugs, so this change is more of a code clean-up.
Related: wordpress-mobile/gutenberg-mobile#3367
How has this been tested?
With the mobile editor empty and the debugger attached, I put a breakpoint in
AztecView.json this line and typed a single "R" character into an empty Paragraph block. Loggingthis.props.textgave:Before this change, I would see this (note the space in the opening
<p>tag:Types of changes
Code clean-up.
Checklist:
*.native.jsfiles for terms that need renaming or removal).