Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary space in HTML tags #30585

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Remove unnecessary space in HTML tags #30585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
340ceb4
Remove unnecessary space in HTML tags
guarani Apr 7, 2021
18e966e
Merge branch 'trunk' into rnmobile/remove-empty-space-in-tags
guarani Apr 7, 2021
3f09863
Updated search snapshot tests
guarani Apr 7, 2021
43b3e8a
Updated file block snapshot tests
guarani Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/block-library/src/file/test/__snapshots__/edit.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ exports[`File block renders file error state without crashing 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >File name</p>",
"text": "<p>File name</p>",
}
}
textAlign="left"
Expand Down Expand Up @@ -187,7 +187,7 @@ exports[`File block renders file error state without crashing 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Download</p>",
"text": "<p>Download</p>",
}
}
textAlign="center"
Expand Down Expand Up @@ -294,7 +294,7 @@ exports[`File block renders file without crashing 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >File name</p>",
"text": "<p>File name</p>",
}
}
textAlign="left"
Expand Down Expand Up @@ -368,7 +368,7 @@ exports[`File block renders file without crashing 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Download</p>",
"text": "<p>Download</p>",
}
}
textAlign="center"
Expand Down
14 changes: 7 additions & 7 deletions packages/block-library/src/search/test/__snapshots__/edit.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports[`Search Block renders block with button inside option 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Search</p>",
"text": "<p>Search</p>",
}
}
triggerKeyCodes={Array []}
Expand Down Expand Up @@ -154,7 +154,7 @@ exports[`Search Block renders block with button inside option 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Search Button</p>",
"text": "<p>Search Button</p>",
}
}
textAlign="center"
Expand Down Expand Up @@ -224,7 +224,7 @@ exports[`Search Block renders block with icon button option matches snapshot 1`]
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Search</p>",
"text": "<p>Search</p>",
}
}
triggerKeyCodes={Array []}
Expand Down Expand Up @@ -371,7 +371,7 @@ exports[`Search Block renders block with label hidden matches snapshot 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Search Button</p>",
"text": "<p>Search Button</p>",
}
}
textAlign="center"
Expand Down Expand Up @@ -441,7 +441,7 @@ exports[`Search Block renders with default configuration matches snapshot 1`] =
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Search</p>",
"text": "<p>Search</p>",
}
}
triggerKeyCodes={Array []}
Expand Down Expand Up @@ -538,7 +538,7 @@ exports[`Search Block renders with default configuration matches snapshot 1`] =
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Search Button</p>",
"text": "<p>Search Button</p>",
}
}
textAlign="center"
Expand Down Expand Up @@ -608,7 +608,7 @@ exports[`Search Block renders with no-button option matches snapshot 1`] = `
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"text": "<p >Search</p>",
"text": "<p>Search</p>",
}
}
triggerKeyCodes={Array []}
Expand Down
2 changes: 1 addition & 1 deletion packages/rich-text/src/component/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,7 @@ export class RichText extends Component {
extraAttributes += ` start=${ this.props.start }`;
}
}
value = `<${ tagName } ${ extraAttributes }>${ value }</${ tagName }>`;
value = `<${ tagName }${ extraAttributes }>${ value }</${ tagName }>`;
}
return value;
}
Expand Down