Navigation: Save theme location on button click #30340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzim
added
[Type] Bug
grzim
requested review from
adamziel,
kevin940726,
noisysocks and
tellthemachines
as code owners
|
Size Change: +49 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Mar 30, 2021
| editMenuName, | ||
| editedMenu, | ||
| menuEntityData, | ||
| editMenuEntityRecord: editEntityRecord, |
There was a problem hiding this comment.
Maybe we can expose this as a function that takes a menu id and menu data as an alternative to returning menuEntityData. The MENU_KIND and MENU_POST_TYPE aren't expected to change.
I also discovered recently that there's a useEntityProp hook, that works similarly to useState, so that wrapping that in some way might also be an option.
There was a problem hiding this comment.
I guess to elaborate more, I'd consider menuEntityData as configuration that can be kept internal to useMenuEntity.
Instead of returning it the hook could return a partially applied version of editEntityRecord so that implementers don't have to worry about passing the MENU_KIND and MENU_POST_TYPE arguments.
Just to also mention that there are other ways of achieving this too.
-
We might consider moving some of this to the edit-navigation store—an action in the navigation store can dispatch actions on another store. Selectors can also select from other stores. We could expose an
editMenuNameaction and agetEditedMenuNameselector for convenience. -
Or there's the
useEntityProphook that I mentioned (https://github.com/WordPress/gutenberg/blob/trunk/packages/core-data/src/entity-provider.js#L74-L117), that provides an easier way to edit individual properties. We could also consider partially applied versions (e.guseMenuEntityProp, or maybe evenuseMenuEntityName/useMenuEntityLocation) of this hook for convenience.
There was a problem hiding this comment.
I have created a separate issue for this #30442
There was a problem hiding this comment.
I like the idea of useMenuEntityProp. Happy to create PR and update existing code.
There was a problem hiding this comment.
Excellent @Mamaduka if you find the time to squeeze that it would be lovely 🙏
gziolo
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closing #30139
Advances #30307
All menage location settings (in sidebar and modal window) are saved upon clicking the
savebutton placed in the header.How has this been tested?
NavigationsavebuttonTypes of changes
Inconsistency fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).