Navigation Editor: Introduce useMenuEntityProp hook #31132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Package] Edit Navigation
[Type] Enhancement
7 tasks
|
Size Change: +2.94 kB (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I think this also fixes #30425. |
There's also #22623, which might influence how the selected menu id works. An option for solving that is to move the selected menu id to the store, and then use the persistence plugin (https://github.com/WordPress/gutenberg/tree/trunk/packages/data/src/plugins/persistence) to sync the value to local storage. |
7 tasks
Mamaduka
force-pushed
the
add/use-menu-entity-prop
branch
from
32c0c39 to
7c295dd
Compare
7 tasks
getdave
reviewed
May 7, 2021
There was a problem hiding this comment.
I tested this manually in the UI and didn't spot any regressions.
That said I'm not clear on
"Add new pages" should be saved when clicking the "Save" button.
From the code it looks like previously when you toggled Add new pages in the Inspector sidebar the menu was automatically saved. Am I right in thinking this PR alters that behaviour so you now manually need to click Save?
If so it feels like that might want to be a separate PR along with a rationale for why this is done. I may have the wrong end of this stick however 😄
With a little more info I would be happy to approve this one.
Sorry about that. I accidentally fixed #30425 when refactoring to use the new hook. The issue also has PR (#30446) that takes a different approach by moving state up the level and using the Happy to remove the "Add new pages" part and create separate PR for the mentioned issue. |
getdave
approved these changes
May 7, 2021
There was a problem hiding this comment.
No worries. Thanks for clarifying.
Happy to remove the "Add new pages" part and create separate PR for the mentioned issue.
Although it seems a bit tedious it might be easier to review in isolation 👍
I'll approve this PR because I know that the saving of the toggle only happened when I clicked the Save button. I'll leave it to you as to whether you want to spin up a separate PR instead.
|
Hi, @getdave I reverted changes for "Add new pages" and will create a separated PR in a bit. Thanks again for the review. |
Sure thing. Let me know and I'll happily review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
useMenuEntityPropas discussed in #30340 (comment). This is auseEntitytPropwrapper hook that encapsulates menu constants and provides an easy way to access/edit individual menu properties.P.S. Maybe we should also introduce the
useSelectedMenuIdhook to get menuId from context. Most of the timeuseSelectedMenuDatahook is used for this.Fixes #30442.
How has this been tested?
Everything should work like before.
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).