Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Editor - theme location change causes rerender #30139

Closed
grzim opened this issue Mar 23, 2021 · 1 comment
Closed

Navigation Editor - theme location change causes rerender #30139

grzim opened this issue Mar 23, 2021 · 1 comment
Assignees
Labels
[Type] Bug An existing feature does not function as intended

Comments

@grzim
Copy link
Contributor

grzim commented Mar 23, 2021

Description

Mentioned in #29458
When a user changes the value in any of the theme location dropdowns in Navigation Editor the entire editor rerenders.

Step-by-step reproduction instructions

Expected behaviour

New menu is applied to the location and the window remains open

Actual behaviour

The entire editor rerenders

Code snippet (optional)

Could be related to useNavigationEditor:
https://github.com/WordPress/gutenberg/blob/trunk/packages/edit-navigation/src/components/layout/index.js#L59
That the navigationPost used is temporarily unavailable, which makes the editor briefly not rendered:
https://github.com/WordPress/gutenberg/blob/trunk/packages/edit-navigation/src/components/layout/index.js#L68

WordPress information

  • Gutenberg version: 10.2.1

Device information

  • Device: MacOS
  • Operating system: Big Sur
  • Browser: Chrome 89
@grzim
Copy link
Contributor Author

grzim commented Apr 1, 2021

closed with #30340

@grzim grzim closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant