Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Block: Removes "Link settings" panel #29664

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Mar 9, 2021

Description

Fixes #23768 by removing the "Link Settings" panel and moving the "Link rel" field into advanced controls.

How has this been tested?

Using wp-env package.

Screenshots

remove-link-settings

Types of changes

  • Removes part of the UI.
  • Moves field into different controls area.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Moves "Link rel" into advanced controls.
@Mamaduka Mamaduka requested a review from ajitbohra as a code owner March 9, 2021 10:05
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Mamaduka! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 9, 2021
@skorasaurus skorasaurus added the [Block] Buttons Affects the Buttons Block label Mar 9, 2021
@skorasaurus
Copy link
Member

skorasaurus commented Mar 9, 2021

Thanks for your PR.
This also partially fulfills #20208 (comment)

I also checked if the community documentation needs to be updated and fortunately, the community documentation is out of date and uses the old button block instead of the new 'buttons' block which includes this.

I did some very basic tests

(create new page, add button - create a link for it; toggle the 'open in new tab' to be active' in the LINK url UI (not in the sidebar),
add an additional link rel value in the panel (e.g. external), click save;
and it looks good to me.

@Mamaduka
Copy link
Member Author

Thanks for testing this @skorasaurus.

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks for working on this @Mamaduka 💯 and congrats on your first GB PR! Really appreciated!

@Mamaduka
Copy link
Member Author

Thanks, @ntsekouras for the review and for restarting the tests.

@ntsekouras ntsekouras merged commit da3f868 into WordPress:trunk Mar 10, 2021
@github-actions github-actions bot added this to the Gutenberg 10.2 milestone Mar 10, 2021
@Mamaduka Mamaduka deleted the remove/button-link-settings branch March 12, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extraneous method (sidebar panel) to adding a link to a Button block
3 participants