Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link relationship label. #20208

Open
Soean opened this issue Feb 13, 2020 · 3 comments
Open

Change link relationship label. #20208

Soean opened this issue Feb 13, 2020 · 3 comments
Labels
Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@Soean
Copy link
Member

Soean commented Feb 13, 2020

The label Link rel is used in the image URL input and in the button block to add link relationship types to the links.

Bildschirmfoto 2020-02-13 um 14 19 16

Bildschirmfoto 2020-02-13 um 14 17 54

I would suggest to change the label to Link relationship, Relation attribute or Relationship attribute. Or should we add a help text? Should we add a link to a help page?

@karmatosed
Copy link
Member

I agree this is super confusing, let's get it fixed! Thanks for reporting.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Feb 25, 2020
@karmatosed
Copy link
Member

I would suggest to change the label to Link relationship, Relation attribute or Relationship attribute. Or should we add a help text? Should we add a link to a help page?

I like idea of some explanation and saying the full term.

@skorasaurus
Copy link
Member

skorasaurus commented Mar 4, 2021

This was also discussed at #29141

There were some great discussions and suggestions there by @SukcesStrony, @jameskoster, and @jarekmorawski.

To recap suggestions:

  1. Move the "Link rel" input to the "Advanced" section as mentioned earlier (Update: This was completed in Button Block: Removes "Link settings" panel #29664)
  2. Add helper text to clarify what the "link rel" is actually for.

Perhaps maybe also hyperlinking "link relation" to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel in the description text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants