Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons Block: Clarify Link Settings #40366

Closed
thehenrybyrd opened this issue Mar 23, 2020 · 4 comments
Closed

Buttons Block: Clarify Link Settings #40366

thehenrybyrd opened this issue Mar 23, 2020 · 4 comments
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Enhancement User Report This issue was created following a WordPress customer report

Comments

@thehenrybyrd
Copy link

thehenrybyrd commented Mar 23, 2020

Steps to reproduce

  1. Create a new Page or Post, or edit an existing one.
  2. Add a new block and select the Buttons Block.
  3. Type your button text.
  4. In Block settings on the right, find "Link Settings".

Here you'll see a text box ("Link rel"), and if you're the average user of the internet, you'll assume that's where your link goes:
Link settings

You'd be incorrect, as this is for the link rel HTML attribute.

What I expected

I expected that the Link Settings area would allow me to choose the link that clicking this button takes visitors to.

What happened instead

Instead, Link Settings includes "open in a new tab" and "Link rel" with no further explanation; entering a URL in "Link rel" results in no warnings, but of course also does not set the button link.

Instead, the link must be set in the Button Block's toolbar, which also includes a "open in a new tab" setting:

Button!

Context / Source

This came up in a chat, where the user I was working with had added their link in "link rel" under Link Settings, but the button wasn't working - clicking it didn't take them to the link. I showed them how to set up the link properly using the Button Block's toolbar, but initially I thought the field in Link Settings simply wasn't working - and this was going to be a bug report.
Instead, I realized that it was for "link rel", and this is not a bug - it's just confusing.

I'd suggest that we add a field in Block Settings > Link Settings, for the URL. Ideally, it can also be filled by searching for existing content, like the existing Block Toolbar link tool.

#19623290-hc

@lancewillett lancewillett added Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Goal] Gutenberg Working towards full integration with Gutenberg [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Enhancement labels Mar 24, 2020
@lancewillett
Copy link
Contributor

Thanks for the report.

Next steps (anyone, including @thehenrybyrd if you have time):

  1. Check if this is WordPress.com specific — if so, note it here
  2. If all WordPress sites with Gutenbeng — we'll need to log it to https://github.com/WordPress/gutenberg/issues and leave a note here to follow up with customer reports once a fix is made, and merged back to WordPress.com

@lancewillett lancewillett added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Mar 24, 2020
@formosattic
Copy link

Link rel is a default setting in Gutenberg, the label is being reviewed for more clarity, WordPress/gutenberg#20208.

There's also ongoing work to improve the UI with editing links from the block toolbar, WordPress/gutenberg#23375.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@kristenzuck kristenzuck added the User Report This issue was created following a WordPress customer report label Apr 29, 2021
@mrfoxtalbot
Copy link

mrfoxtalbot commented Sep 2, 2024

I do not think this is no longer relevant given the new structure of the link tools:

Screenshot 2024-09-02 at 15 59 03

Marking this as fixed

(Also.. hi Alicia 👋 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Enhancement User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

5 participants