Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous method (sidebar panel) to adding a link to a Button block #23768

Closed
richtabor opened this issue Jul 7, 2020 · 2 comments · Fixed by #29664
Closed

Remove extraneous method (sidebar panel) to adding a link to a Button block #23768

richtabor opened this issue Jul 7, 2020 · 2 comments · Fixed by #29664
Assignees
@richtabor
Labels
[Block] Buttons Affects the Buttons Block Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@richtabor
Copy link
Member

Is your feature request related to a problem? Please describe.
There are currently multiple ways to add a link to the Button block. Following the pattern of removing duplicate methods for the same actions, as seen in the Heading block #20246, I suggest we remove the Link Settings panel from the Settings sidebar of the Button block.

This would clean up duplicate UI and help simplify the experience.

Screen_Shot_2020-07-07_at_12 52 33_PM
@richtabor richtabor added Needs Design Feedback Needs general design feedback. [Block] Buttons Affects the Buttons Block labels Jul 7, 2020
@richtabor richtabor mentioned this issue Jul 20, 2020
Closed
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 20, 2020
@richtabor richtabor mentioned this issue Jul 24, 2020
Open
@paaljoachim
Copy link
Contributor

That is a very good idea, Rich!
I will ping Joen and Mark to get an ok to move forward with this, as they might see something you and I have missed.
@jasmussen @mapk

@jasmussen
Copy link
Contributor

The "open in new tab" can certainly be removed!

Screenshot 2020-12-16 at 09 38 23

However we still need to a place for the link rel:

Screenshot 2020-12-16 at 09 38 29

Should we put that under "Advanced"? I'd be okay with that.

@Mamaduka Mamaduka mentioned this issue Mar 9, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richtabor richtabor

Labels
[Block] Buttons Affects the Buttons Block Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
3 participants
@jasmussen @richtabor @paaljoachim