-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface package: move MainDashboardButton slot #27213
Conversation
Size Change: -41 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
3f277ef
to
c3e7c54
Compare
@@ -12,7 +12,7 @@ import { __ } from '@wordpress/i18n'; | |||
import { addQueryArgs } from '@wordpress/url'; | |||
import { wordpress } from '@wordpress/icons'; | |||
|
|||
function FullscreenModeClose( { showTooltip } ) { | |||
function FullscreenModeClose( { showTooltip, icon, href } ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these customization options to make it consistent with existing docs and back button in navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested and it works fine. With and without custom fill. ✅
Description
See the related discussion here 410333b#commitcomment-44381621.
The purpose of this change is to safeguard against similar problems in the future. It might also make more sense to organize things this way now, since the buttons being replaced with the slot are no longer the same. In post editor it's the W icon button, while in site editor it's
Back to Dashboard
nav item. That means that in 3rd party integration we'd always have to check the editor type before providing the appropriate fill with the old approach.Closes #27158
How has this been tested?
For post editor:
For site editor:
Screenshots
Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist: