Nav sidebar: update MainDashboardButton slot usages

[vindl]

Changes proposed in this Pull Request

Updates MainDashboardButton slot usages since it was moved from interface to edit-post package. See WordPress/gutenberg#27213

Note: This shouldn't be merged to Dotcom until the corresponding Gutenberg plugin version (9.5) is deployed to production.

Testing instructions

• When Gutenberg 9.5 is available on Dotcom smoke test the Nav Sidebar and make sure that everything still works.

[matticbot]

Test live: https://calypso.live/?branch=update/nav-sidebar-slot

[matticbot]

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D53240-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~94 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
manifest       +641 B  (+0.9%)      +94 B  (+0.6%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~13610 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding       +47794 B  (+2.8%)   +13551 B  (+3.0%)
entry-main                  -808 B  (-0.1%)      +73 B  (+0.0%)
entry-domains-landing       +161 B  (+0.0%)      +14 B  (+0.0%)
entry-login                 +155 B  (+0.0%)      +36 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4567 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
signup                     +2667 B  (+0.8%)     +939 B  (+1.1%)
settings                   +1670 B  (+0.3%)     -101 B  (-0.1%)
woocommerce                +1630 B  (+0.1%)     -112 B  (-0.0%)
account                    +1628 B  (+0.3%)      -94 B  (-0.1%)
reader                     +1539 B  (+0.3%)    +1598 B  (+1.1%)
jetpack-connect            +1507 B  (+0.2%)     -229 B  (-0.1%)
plans                      +1454 B  (+0.2%)     +567 B  (+0.3%)
hosting                    +1454 B  (+0.5%)     -798 B  (-1.0%)
jetpack-cloud-pricing      +1427 B  (+0.4%)     -337 B  (-0.3%)
gutenberg-editor           +1335 B  (+0.3%)     +449 B  (+0.4%)
backup                      +105 B  (+0.0%)     +797 B  (+0.7%)
activity                    +105 B  (+0.0%)     +797 B  (+0.5%)
wp-super-cache               +70 B  (+0.0%)       +4 B  (+0.0%)
settings-security            +70 B  (+0.0%)       +3 B  (+0.0%)
settings-performance         +70 B  (+0.0%)       -1 B  (-0.0%)
settings-discussion          +70 B  (+0.0%)       +0 B
privacy                      +70 B  (+0.0%)       +3 B  (+0.0%)
marketing                    +70 B  (+0.0%)       +5 B  (+0.0%)
earn                         +70 B  (+0.0%)       +2 B  (+0.0%)
settings-writing             +69 B  (+0.0%)       +6 B  (+0.0%)
posts-custom                 +69 B  (+0.0%)       +7 B  (+0.0%)
posts                        +69 B  (+0.0%)       +7 B  (+0.0%)
plugins                      +69 B  (+0.0%)       +7 B  (+0.0%)
email                        -57 B  (-0.0%)     -767 B  (-0.8%)
site-purchases               +49 B  (+0.0%)      +13 B  (+0.0%)
purchases                    +49 B  (+0.0%)       +7 B  (+0.0%)
domains                      +47 B  (+0.0%)      +84 B  (+0.0%)
people                       -38 B  (-0.0%)      -16 B  (-0.0%)
home                         +37 B  (+0.0%)     +364 B  (+0.3%)
devdocs                      -31 B  (-0.0%)      -21 B  (-0.0%)
checkout                     -23 B  (-0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~7163 bytes added 📈 [gzipped])

name                                                      parsed_size           gzip_size
async-load-calypso-blocks-editor-launch-modal                 +8766 B  (+3.9%)    +2016 B  (+3.4%)
async-load-calypso-blocks-editor-checkout-modal               +8320 B  (+0.7%)    +2018 B  (+0.7%)
async-load-design-wordpress-components-gallery                +4103 B  (+0.6%)     +407 B  (+0.3%)
async-load-design-blocks                                      +1740 B  (+0.1%)      -88 B  (-0.0%)
async-load-design-playground                                  +1680 B  (+0.1%)     +110 B  (+0.0%)
async-load-design                                             +1680 B  (+0.1%)      -84 B  (-0.0%)
async-load-quick-language-switcher                            +1635 B  (+1.2%)      -67 B  (-0.2%)
async-load-calypso-components-web-preview-component           +1464 B  (+0.3%)       -7 B  (-0.0%)
async-load-calypso-blocks-inline-help                          +116 B  (+0.1%)       +6 B  (+0.0%)
async-load-calypso-blocks-inline-help-popover                  +109 B  (+0.0%)    +1148 B  (+1.1%)
async-load-signup-steps-domains                                 -37 B  (-0.0%)      -16 B  (-0.0%)
async-load-calypso-reader-site-stream                           +35 B  (+0.1%)       +3 B  (+0.0%)
async-load-calypso-reader-search-stream                         +35 B  (+0.0%)       +4 B  (+0.0%)
async-load-calypso-reader-following-manage                      +35 B  (+0.0%)       +4 B  (+0.0%)
async-load-calypso-reader-feed-stream                           +35 B  (+0.1%)       +3 B  (+0.0%)
async-load-calypso-my-sites-current-site-domain-warnings        +14 B  (+0.0%)      -80 B  (-0.5%)
async-load-calypso-components-jetpack-sidebar                   +14 B  (+0.0%)       +7 B  (+0.1%)
async-load-calypso-my-sites-sidebar-unified                     +13 B  (+0.0%)       +6 B  (+0.0%)
async-load-calypso-my-sites-sidebar                             +13 B  (+0.0%)      +63 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[vindl]

The test failures here are expected since the package changes have not been published yet.

[p-jackson]

I've just incorporated my feedback into this PR. It made more sense than leaving super specific feedback, but feel free to go ahead and change any of my changes.

In particular I've removed the unit test and replaced it with the e2e spec. Now that MainDashboardButton has moved from a bundled feature to one that's accessible on the wp global it no longer makes sense to test that the experimental feature happens to be available in the version that's in node_modules.

Once GB 9.5 is deployed to edge stickered sites we should be able to add the [Status] Needs e2e Testing Gutenberg Edge label to this PR to make sure tests pass.

[p-jackson]

Looks like GB 9.6 is deployed to edge sites now so this can be looked at again. Do you have idea about rollout plans for this @vindl? Do we need to merge this close to simultaneously with the rollout of GB 9.6?

[vindl]

Looks like GB 9.6 is deployed to edge sites now so this can be looked at again. Do you have idea about rollout plans for this @vindl? Do we need to merge this close to simultaneously with the rollout of GB 9.6?

I assumed that we'd have to rollout simultaneously with GB 9.6, but I tested it on edge sites and it still works as expected, which would indicate that it's not necessary?

[vindl]

Closing in favor of #48729.