Site Editor: Update back button URL #36313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
|
Hi, @jameskoster I tried to follow our specs for this enhancement, but it might be hard to implement this logic:
The Site Editor cannot distinguish between editing a template or editing a page that uses the said template. If I can come up with something later, I'll push a fix for this. |
Mamaduka
commented
Nov 8, 2021
packages/edit-site/src/components/header/navigation-link/index.js
Outdated
Show resolved
Hide resolved
|
Size Change: +48 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
update/site-editor-goback-btn
branch
from
8762082 to
360a06a
Compare
|
Thanks, it's working well for templates and template parts 👍 Perhaps going back to Appearance > Templates from Appearance > Editor is ok 🤔 I'd love more design input on that cc @kellychoffman. |
kevin940726
reviewed
Nov 9, 2021
packages/edit-site/src/components/header/navigation-link/index.js
Outdated
Show resolved
Hide resolved
Mamaduka
force-pushed
the
update/site-editor-goback-btn
branch
from
360a06a to
933942f
Compare
jameskoster
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Working 👍
Going from Editor (beta) to Appearance > Templates still feels a little strange to me, but it's the best we can do for now. Hopefully #36348 will help make this feel less strange.
|
Thanks for testing, @jameskoster and @kevin940726. I will merge this once the issue of the failing tests is resolved in WP Core. |
I find this behavior unexpected. I'd expect the W button to take me back to the Dashboard, or the previously active screen. That way it would be consistent with the same button in the post editor. I also think we should make this button extendable via a slot, similarly to how it's done in the post editor, to allow 3rd party integrations to override the URL and site icon when needed. I've done something similar before in #27213, but we refactored and removed that when Browsing Sidebar was introduced. I think we should go back to this approach now that it's being removed. |
100% - I think this was missed accidentally in #36194 The Ideally we would use this same Slot/Fill here - similar to how the post editor uses its equivalent. |
|
Thanks for the feedback, @vindl, and @Addison-Stavlo. I can address SlotFill as a follow-up PR, but probably after WP 5.9 since it's an enhancement.
It more or less works the same way. The only exception is that the user returns to the list template view after accessing the Editor screen. Many of these are last-minute changes, and I don't expect UX to be the same in a month or two. |
|
@Mamaduka after the Browsing Sidebar refactor we are depending on the presence of this slot to override the default W button behavior in our 3rd party Site Editor integration. Given that this functionality was present before, I view this as extensibility regression after the latest updates. It's really important to us to have this present in 5.9 release. |
|
@vindl Can you create a new issue for SlotFill to add it to the "WP 5.9 Must Haves" list as a regression. |
|
@Mamaduka I filed an issue for it here #36366. cc @noisysocks |
Mamaduka
force-pushed
the
update/site-editor-goback-btn
branch
from
933942f to
509fcb4
Compare
|
I'm going to merge this. It looks like the "Pull request automation" check got stuck, but actual tests are all green. |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The follow-up to a #36294 (comment)
Update logic for the W go bach button and return the user to a Templates or Template Parts list view.
How has this been tested?
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).