-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm org scope to WordPress dependencies #2172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Ship it, it works great 👍
Ensure loaded in correct order
8314260
to
cf5a450
Compare
Codecov Report
@@ Coverage Diff @@
## master #2172 +/- ##
=========================================
+ Coverage 22.15% 22.3% +0.14%
=========================================
Files 138 137 -1
Lines 4283 4291 +8
Branches 723 722 -1
=========================================
+ Hits 949 957 +8
- Misses 2814 2815 +1
+ Partials 520 519 -1
Continue to review full report at Codecov.
|
Related: #941
Related: #1205
This pull request seeks to add the WordPress npm organization scope to all WordPress dependency imports. It is a further realization of the intent for these top-level folders to be distributed as independent packages.
Other side-benefits include:
wp_register_script
script dependenciesImplementation notes:
This will be hellish to rebase, so I'd prefer not to let this one linger.
Testing instructions:
This is difficult to test because it touches nearly every file in the application. Verify through
npm run build
,npm run dev
,npm test
that no errors occur, and that no regressions or console errors occur by thorough use of the application.