Add captions to gallery block #1831
Conversation
mtias
added
[Feature] Blocks
| left: 0; | ||
| right: 0; | ||
| figcaption { | ||
| position: static; |
There was a problem hiding this comment.
Why is this needed? I believe MCE will re-add it as inline style.
There was a problem hiding this comment.
The positioning is a bit messed up because we'd want to apply it to figcaption on the front end, but to editable in the editor.
|
I can use some clarification for user experience, the core Media Modal which is used for selecting the image also includes ordering images, and editing captions as part of the standard create gallery flow. This is improved on create with PR #1820 Do we want those interactions to happen within Gutenberg block also, or alternatively could remove from modals (might require core-media work), or just manage within the modals? cc: @jasmussen and since he's on holiday, @melchoyce |
In general, the more interactions that can happen on the block itself (without adding undue complexity), the better. The idea is that you should be able to get fully going with a block, with using only the block interface itself. Any advanced configuration can happen in the sidebar/inspector. See also https://github.com/WordPress/gutenberg/blob/master/docs/design.md#block-interface--sidebar--inspector In the case of the gallery, I see the media modal eventually going away entirely. That is, everything we want to port from the media modal, we should, including sort order. But this doesn't have to happen immediately, and the idea is to move towards "the block" being the only interface you ever have to learn. |
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { __ } from 'i18n'; |
There was a problem hiding this comment.
Note with #2172, these need to be updated to prefix the dependencies with @wordpress/. You will need to perform a rebase against the latest version of master and apply your changes:
git fetch origin
git rebase origin/master
|
Looks like this has been superseded by #4199 |
Closes #1443.